Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add regression tests for server-side-rendering #1174

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore: add regression tests for server-side-rendering #1174

merged 1 commit into from
Jun 20, 2024

Conversation

NamNg1121
Copy link
Contributor

No description provided.

@NamNg1121 NamNg1121 requested a review from Brailor March 20, 2023 12:54
@NamNg1121 NamNg1121 self-assigned this Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 20, 2023 •
edited
Loading

Description Bundle size (gzipped)
Target branch package bundle size. (master)
Target branch base commit:
master/fdba0f5b156aab5055c70ed03a0a72f1dd92e892		 1160 kB
Pull Request branch package bundle size. (INSTUI-3743-add-next-js-support-to-the-regression-testing-suite)
HEAD commit at PR branch:
INSTUI-3743-add-next-js-support-to-the-regression-testing-suite/c351f840f9a00dab17e01ede882e9264b8c89d62		 1160 kB
Same bundle size.

Generated by 🚫 dangerJS against c351f84

@github-actions
Copy link

Preview URL: https://1174--preview-instui.netlify.app

Brailor
Brailor reviewed Mar 24, 2023
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
regression-test/src/pages/_app.tsx Outdated Show resolved Hide resolved
@NamNg1121 NamNg1121 force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch from c52de80 to c351f84 Compare March 29, 2023 05:03
@NamNg1121 NamNg1121 requested a review from Brailor March 29, 2023 05:06
Brailor
Brailor reviewed Mar 30, 2023
View reviewed changes
regression-test/package.json Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@matyasf matyasf changed the title chore: add regression tests for server-sire-rendering chore: add regression tests for server-side-rendering Jun 9, 2023
@matyasf matyasf force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch from c351f84 to d86d7b3 Compare July 24, 2023 10:17
@HerrTopi HerrTopi requested review from matyasf and HerrTopi and removed request for matyasf and HerrTopi August 22, 2023 13:56
@joyenjoyer joyenjoyer force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch from d86d7b3 to 28eb65b Compare March 1, 2024 15:41
@joyenjoyer joyenjoyer force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch from 28eb65b to a09ede7 Compare June 11, 2024 13:45
@joyenjoyer joyenjoyer self-assigned this Jun 12, 2024
@joyenjoyer joyenjoyer force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch 3 times, most recently from ca6e394 to 9af67fb Compare June 18, 2024 15:42
@joyenjoyer joyenjoyer force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch 3 times, most recently from 0ebc96c to 3a497a0 Compare June 18, 2024 15:50
balzss
balzss approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments but overall looks great, nice work

regression-test/README.md Outdated Show resolved Hide resolved
regression-test/README.md Outdated Show resolved Hide resolved
regression-test/src/app/components/[componentName]/page.tsx Show resolved Hide resolved
@joyenjoyer joyenjoyer force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch from 3a497a0 to 9e00c13 Compare June 19, 2024 14:07
@joyenjoyer joyenjoyer force-pushed the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch from 9e00c13 to 5465ea2 Compare June 19, 2024 14:10
@joyenjoyer joyenjoyer merged commit e03f40c into master Jun 20, 2024
8 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-3743-add-next-js-support-to-the-regression-testing-suite branch June 20, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brailor Brailor Brailor left review comments

@joyenjoyer joyenjoyer joyenjoyer left review comments

@git-nandor git-nandor git-nandor approved these changes

@balzss balzss balzss approved these changes

@HerrTopi HerrTopi Awaiting requested review from HerrTopi

Assignees

@joyenjoyer joyenjoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NamNg1121 @balzss @joyenjoyer @Brailor @git-nandor