add jest + react-testing library with example and docs guide #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1246--preview-instui.netlify.app |
balzss
changed the title
matyasf
requested changes
Aug 9, 2023
packages/ui-avatar/package.json
Outdated
| @@ -34,11 +34,14 @@ | |||
| "prop-types": "^15.8.1" | |||
| }, | |||
| "devDependencies": { | |||
| "@instructure/ui-axe-check": "workspace:^", | |||
There was a problem hiding this comment.
We should use here exact dependency numbers like with other internal references
| preset: 'ts-jest', | ||
| testEnvironment: 'jsdom', | ||
| testMatch: ['**/__new-tests__/**/*.test.tsx'] | ||
| } |
There was a problem hiding this comment.
We should calculate test coverage too (and later fail the build if its below 80%)
There was a problem hiding this comment.
I've added the coverage threshold to the config. Once we are ready, we can add the --coverage flag to the script and it should work.
matyasf
approved these changes
Aug 10, 2023
HerrTopi
approved these changes
Aug 10, 2023
balzss
force-pushed
the
feat/new-testing-libraries2
branch
2 times, most recently
from
14cc9c2
to
90e5b92
Compare
…ting library and convert ui-avatar tests
balzss
force-pushed
the
feat/new-testing-libraries2
branch
from
1d7777f
to
88c775d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-3818
ui-avatartests as example and skip old onestest plan
yarn test:new-> all 26 should passui-avatartests withnpx ui-scripts test --path packages/ui-avatar-> all 26 should be skipped (not including the theme related ones)