DateInput2

[balzss]

test plan:

• check the example for DateInput2 with and without the year picker -> try if works as expected
• try out some props
• read docs if it makes sense
• check a11y
• check the notice on the old DateInput docs

Closes: INSTUI-4097

[github-actions]

Preview URL: https://1556--preview-instui.netlify.app

[matyasf]

• when I enter an invalid date in the first example the invalid date message flashes for a second but then disappears
• as I mentioned before it should be nice if I could move with arrows in calendar dates, but as I understand this needs to happen in the Calendar component.

Mz biggest concern that its using moment which is an out of date library. if we switch to a more modern lib, it will be a breaking change for our users.
We should investigate how a polyfill for the new Temporal API can replace moment for us.

[balzss]

• when I enter an invalid date in the first example the invalid date message flashes for a second but then disappears
• as I mentioned before it should be nice if I could move with arrows in calendar dates, but as I understand this needs to happen in the Calendar component.

Mz biggest concern that its using moment which is an out of date library. if we switch to a more modern lib, it will be a breaking change for our users. We should investigate how a polyfill for the new Temporal API can replace moment for us.

1. good catch, this is fixed now
2. yes, this should be done in Calendar
3. regarding moment: end users (devs) don't really interact or depend on moment because this component simply returns a date string (just like the original DateInput) but is uses moment internally to parse and validate the dates. both of these can be replaced somewhat easily with the native Date object but that causes a small mismatch in the validation of this and Calendar component. this is addressed in the code with a comment and it won't change anything for users when we remove it later

[joyenjoyer]

typo: imporing

[joyenjoyer]

When I set size to either small or medium, no height or width changes only when it is set to large. Is that an expected behavior?

[balzss]

When I set size to either small or medium, no height or width changes only when it is set to large. Is that an expected behavior?

nice catch! the icon wasn't changing size with the input so it prevented it to become small, now it's fixed

[joyenjoyer]

nice job!

[matyasf]

looks good, very nice work!
FYI we have a @isWIP tag that you can use in our markdown files that wont make them appear in the sidebar (but you can see it by typing the URL)

[balzss]

looks good, very nice work! FYI we have a @isWIP tag that you can use in our markdown files that wont make them appear in the sidebar (but you can see it by typing the URL)

good to know but I'm not sure if we want that since the component can more or less replace most of the current uses of the original DateInput and we explicitly recommend it in the docs