INSTUI-3794 update dependencies. Major updates are TS, Vitest #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1578--preview-instui.netlify.app |
matyasf
commented
Jul 11, 2024
| @@ -29,7 +29,7 @@ | |||
| "@instructure/ui-dom-utils": "9.2.0", | |||
| "@instructure/ui-react-utils": "9.2.0", | |||
| "@instructure/uid": "9.2.0", | |||
| "keycode": "^2.2.1" | |||
There was a problem hiding this comment.
Its better to define supported versions for user-consumed packages in the broadest range possible to reduce the chance of including it twice in their builds. Luckily we just have a few such dependencies
balzss
approved these changes
Jul 15, 2024
git-nandor
approved these changes
Jul 16, 2024
TEST PLAN: run scripts that are not run automatically by CI, e.g. bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST PLAN:
run scripts that are not run automatically by CI, e.g. bump