feat(many): rewrite color system #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1588--preview-instui.netlify.app |
balzss
requested changes
Jul 18, 2024
git-nandor
approved these changes
Jul 18, 2024
matyasf
requested changes
Jul 18, 2024
joyenjoyer
force-pushed
the
new_color_system
branch
from
0547120
to
94af2f4
Compare
HerrTopi
force-pushed
the
new_color_system
branch
2 times, most recently
from
4423fa2
to
21187af
Compare
matyasf
approved these changes
Jul 29, 2024
HerrTopi
force-pushed
the
new_color_system
branch
from
f7951ff
to
9638e58
Compare
|
joyenjoyer
force-pushed
the
new_color_system
branch
from
98156ea
to
8ed731a
Compare
HerrTopi
force-pushed
the
new_color_system
branch
2 times, most recently
from
fd68e35
to
f3121c3
Compare
Closes: INSTUI-4100 BREAKING CHANGE: Breaks color overrides in certain cases
The issue was that the entry before the hover CSS selector contained an extra '}' sign, which causes Emotion to go crazy and put subsequent CSS classes into the global scope instead of just the specific DOM part
Closes: INSTUI-4144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Breaks color overrides in certain cases