Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-date-input,ui-text-input): add custom validation function #1592

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat(ui-date-input,ui-text-input): add custom validation function #1592

merged 1 commit into from
Jul 25, 2024

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Jul 19, 2024

and fix small layout issue

@balzss balzss self-assigned this Jul 19, 2024
@balzss balzss requested a review from matyasf July 22, 2024 08:39
matyasf
matyasf requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is off with the validation, it does not trigger if I click outside from the calendar just when I unfocus the text field.

Screen.Recording.2024-07-23.at.11.23.38.mov

@balzss
Copy link
Contributor Author

balzss commented Jul 23, 2024

something is off with the validation, it does not trigger if I click outside from the calendar just when I unfocus the text field.

Screen.Recording.2024-07-23.at.11.23.38.mov

oh, you are right! it validates on input blur and I didn't consider this scenario. will fix it

@balzss balzss force-pushed the feat/DateInput2-custom-validation branch from dd459fb to bf06de8 Compare July 24, 2024 10:15
@balzss balzss requested a review from matyasf July 24, 2024 10:15
@instructure instructure deleted a comment from github-actions bot Jul 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-25 06:30 UTC

@balzss balzss force-pushed the feat/DateInput2-custom-validation branch from bf06de8 to 233bf7e Compare July 25, 2024 06:17
@balzss balzss merged commit 77218be into master Jul 25, 2024
8 of 9 checks passed
@balzss balzss deleted the feat/DateInput2-custom-validation branch July 25, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-nandor git-nandor git-nandor approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@balzss balzss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balzss @matyasf @git-nandor