INSTUI-4145 MenuItem's onSelect type did not expose its value and selected types
#1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1597--preview-instui.netlify.app |
joyenjoyer
approved these changes
Jul 24, 2024
balzss
approved these changes
Jul 25, 2024
…elected types Closes: INSTUI-4145 This is uses MenuItemProps instead, this type is exported TEST PLAN: import this component and check in the IDE that you can use the onSelect prop in TypeScript
matyasf
force-pushed
the
menuitem_type_fix
branch
from
036531b
to
86b38d2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is uses MenuItemProps instead, this type is exported. Also added some documentation for some props.
TEST PLAN:
import this component and check in the IDE that you can use the onSelect prop in TypeScript