chore: fix build on Windows #1606
Conversation
| @@ -11,7 +11,7 @@ | |||
| "homepage": "https://instructure.design", | |||
| "bugs": "https://github.com/instructure/instructure-ui/issues", | |||
| "scripts": { | |||
| "prestart": "npm run build:scripts:ts && node -e 'import(\"./lib/build-docs.mjs\").then(file => file.buildDocs());'\n", | |||
There was a problem hiding this comment.
Windows does not like such a fancy command at all :/ had to move it to a file
| @@ -42,9 +43,9 @@ export default { | |||
| }, | |||
| handler: async (argv) => { | |||
| const configFile = path.join(process.cwd(), argv.config) | |||
| const config = await import(configFile) | |||
| const configFileURL = pathToFileURL(configFile) | |||
| const config = await import(configFileURL) | |||
There was a problem hiding this comment.
import() for files must begin with file://, this is added by this built in helper
|
packages/__docs__/build-docs.mjs
Outdated
| // scripts must be built from .ts files before this is run | ||
| import {buildDocs} from './lib/build-docs.mjs' | ||
|
|
||
| buildDocs() |
There was a problem hiding this comment.
was this file created in windows? I think this file ending is not compatible with unix EOF. I think editing this file in macos should solve this
There was a problem hiding this comment.
also the same file name with lib/build-docs.mjs is a bit confusion. I'm wondering if there's that file already, can't that one be run instead?
There was a problem hiding this comment.
There is a way not to create a new file and not use fancy syntax in package.json but its also ugly: https://stackoverflow.com/a/75760840 What do you think?
There was a problem hiding this comment.
fixed it, now it doesn't need an extra file
balzss
force-pushed
the
fix_windows_build
branch
from
01d4391
to
eddc67e
Compare
matyasf
force-pushed
the
fix_windows_build
branch
from
eddc67e
to
b468d3a
Compare
not fully fixed yet, cant commit due to conventional-changelog/commitlint#4106
what works:
bootstrapdevtest:vitestalmost (1 test fails for some reason)