Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTUI-4143 ui-color-picker,ui-color-utils: fix corrupted CJS build #1609

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

matyasf
Copy link
Collaborator

@matyasf matyasf commented Jul 29, 2024

babel-plugin-transform-imports cannot handle if there are multiple exports from a file. This commit adds a default export which works with this plugin

TEST PLAN:
make sure the CJS builds do not try to run function from color utils without importing them

@matyasf matyasf requested review from HerrTopi and balzss July 29, 2024 14:05
@matyasf matyasf self-assigned this Jul 29, 2024
Copy link

github-actions bot commented Jul 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-30 19:30 UTC

babel-plugin-transform-imports cannot handle if there are multiple exports from a file. This commit
adds a default export which works with this plugin
TEST PLAN:
make sure the CJS builds do not try to run function from color utils without importing them
@balzss balzss merged commit e1016be into master Jul 30, 2024
9 checks passed
@balzss balzss deleted the colorpicker_cjs_fix branch July 30, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants