Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ui-modal,ui-tray): function based examples are added to Modal an… #1613

Merged

Conversation

ToMESSKa
Copy link
Contributor

…d Tray

Closes: INSTUI-4149

@ToMESSKa ToMESSKa self-assigned this Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1613/
on branch gh-pages at 2024-08-15 07:51 UTC

@ToMESSKa ToMESSKa marked this pull request as ready for review July 31, 2024 09:53
onClick={() => {
this.setState({ open: true })
}}
ref={(c) => (this._showButton = c)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt seem to do anything, you can delete it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


const Example = () => {
const [open, setOpen] = useState(false)
const showButtonRef = useRef(null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can delete this one too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ToMESSKa ToMESSKa force-pushed the INSTUI-4149_write_functional_examples_for_tray_and_modal branch from f79914b to 5b136c9 Compare August 15, 2024 07:46
@ToMESSKa ToMESSKa requested a review from matyasf August 15, 2024 07:47
@ToMESSKa ToMESSKa merged commit 3492008 into master Aug 21, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4149_write_functional_examples_for_tray_and_modal branch August 21, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants