docs(many): function based examples are added to ToggleButton, Trucat… #1629
Conversation
|
|
|
||
| - ```js | ||
| const InverseExample = () => { | ||
| const [lockedStatus, setLockedStatus] = useState('off') |
There was a problem hiding this comment.
the original example is kind of strange for this. lockedStatus could be a boolean variable so this strange conversion wouldn't be needed
There was a problem hiding this comment.
I simplified the code with a boolean
| <ToggleButton | ||
| status={locked ? 'pressed' : 'unpressed'} | ||
| color="primary-inverse" | ||
| renderIcon={locked ? IconLockSolid : IconUnlockLine} | ||
| screenReaderLabel={locked ? 'Unlock assignment' : 'Lock assignment'} | ||
| renderTooltipContent={locked ? 'Unlock' : 'Lock'} | ||
| onClick={this.handleLocked} | ||
| onClick={handleLocked} | ||
| mountNode={() => document.getElementById('inverseToggleContainer')} |
There was a problem hiding this comment.
this prop is also a bit strange. does it work without it?
There was a problem hiding this comment.
I works without it, removed
| render(<InverseExample />) | ||
| ``` | ||
| render(<InverseExample />) | ||
| ``` |
There was a problem hiding this comment.
if there was no problem with my suggestions could you please fix the original examples too?
| - ```javascript | ||
| class Example extends React.Component { | ||
| state = { | ||
| value: '2020-05-18T23:59:00' |
There was a problem hiding this comment.
this is a strange default value if the steps are 15 mins which makes is value basically invalid. could be better to remove or change it
There was a problem hiding this comment.
I remember that this use case was specifically requested (default value could be something that is not in the dropdown), so I'd leave it here. The explanation when this is used to set a deadline its default is 1 min before midnight, which the user should be able to change.
When we make a new TimeSelect it should handle this better.
There was a problem hiding this comment.
I left this unchanged.
…eText and TimeSelect Closes: INSTUI-4153
ToMESSKa
force-pushed
the
INSTUI-4153_write_functional_examples_for_truncatetext_togglebutton_and_timeselect
branch
from
8c2ca4b
to
1d3e78a
Compare
ToMESSKa
deleted the
INSTUI-4153_write_functional_examples_for_truncatetext_togglebutton_and_timeselect
branch
…eText and TimeSelect
Closes: INSTUI-4153