Datavizcolors #1634
Merged
Datavizcolors #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HerrTopi
force-pushed
the
datavizcolors
branch
2 times, most recently
from
f6ed085
to
6c3755e
Compare
HerrTopi
force-pushed
the
datavizcolors
branch
from
3f539c8
to
6d843eb
Compare
joyenjoyer
reviewed
Aug 15, 2024
packages/__docs__/globals.js
Outdated
| @@ -82,7 +86,10 @@ const globals = { | |||
| useEffect, | |||
| useState, | |||
| useRef, | |||
| ThemeColors | |||
| additionalPrimitives, | |||
| datavisualization, | |||
There was a problem hiding this comment.
Consider camelCase (dataVisualization) for this as it is seen in other names.
There was a problem hiding this comment.
Nice catch, updated
HerrTopi
force-pushed
the
datavizcolors
branch
5 times, most recently
from
1fe3564
to
af6e433
Compare
matyasf
requested changes
Aug 16, 2024
docs/guides/color-system.md
Outdated
|
|
||
| ### Colors | ||
|
|
||
| Colors are divided into two main technical groups: primitive and semantic colors. Primitive colors store the pure hex values. The primitive colors are the building blocks of the semantic colors. Examples of semantic colors: UI, Contrasts, Datavisualization. |
There was a problem hiding this comment.
an extra sentence about what semantic colors are would be good here.
matyasf
requested changes
Aug 21, 2024
matyasf
force-pushed
the
datavizcolors
branch
2 times, most recently
from
cdb8083
to
7e6eed3
Compare
Closes: INSTUI-4174, INSTUI-4175, INSTUI-4176, INSTUI-4177
HerrTopi
force-pushed
the
datavizcolors
branch
from
7e6eed3
to
85c6cbe
Compare
matyasf
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4174, INSTUI-4175, INSTUI-4176, INSTUI-4177