fix(ui-options): subgroup titles in Options are now announnced by Tal… #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ToMESSKa
force-pushed
the
INSTUI-4235_a_11_y_subgroup_titles_are_not_read_with_talkback_in_options
branch
from
ada13fd
to
953fcb8
Compare
balzss
approved these changes
Oct 4, 2024
matyasf
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Looks good, just a hint, be careful when using DOM globals like navigator, a lot of them are undefined in Node, resulting in errors when using SSR. I've tested this one with our regression testing app and it works OK because Node returns Node.js/22, but this code might break in some SSR edge cases like using Bun (havent tested it) or just this value is used in a mobile browser
matyasf
requested changes
Oct 7, 2024
matyasf
reviewed
Oct 8, 2024
| return ( | ||
| <span | ||
| id={this._labelId} | ||
| role="presentation" | ||
| aria-hidden="true" | ||
| aria-hidden={isAndroidOrIOS ? 'false' : 'true'} |
There was a problem hiding this comment.
Can you please leave a comment detailing why this is needed?
There was a problem hiding this comment.
Rewrote the code with ua-parser-js and left a comment too
ToMESSKa
force-pushed
the
INSTUI-4235_a_11_y_subgroup_titles_are_not_read_with_talkback_in_options
branch
2 times, most recently
from
a0e7284
to
2cca1ce
Compare
matyasf
approved these changes
Oct 9, 2024
…d by TalkBack and iOS VoiceOver Closes: INSTUI-4235
ToMESSKa
force-pushed
the
INSTUI-4235_a_11_y_subgroup_titles_are_not_read_with_talkback_in_options
branch
from
2cca1ce
to
80feb80
Compare
ToMESSKa
changed the title
balzss
deleted the
INSTUI-4235_a_11_y_subgroup_titles_are_not_read_with_talkback_in_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kBack and iOS VoiceOver
Closes: INSTUI-4235
ISSUE:
Subgroup titles are not read in Options with Android Talkback and iOS Voiceover. It works perfectly on Mac Voiceover and on Windows.
TEST PLAN: