Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-avatar,ui-source-code-editor): fix docs a11y issues #1741

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Oct 17, 2024

INSTUI-4248
INSTUI-4249
INSTUI-4250
INSTUI-4270
INSTUI-4289

test plan:

  • docs landing page "what's new" section now has white bg for better contrast
  • docs side nav open button now have aria-expanded="false so screenreaders announce that it's closed
  • added screen reader label to instructure logo in sidenav
  • ui-avatar has aria-hidden -> this is now mentioned in the README
  • source code editor example for syntax highlight now has a label

@balzss balzss self-assigned this Oct 17, 2024
@balzss
Copy link
Contributor Author

balzss commented Oct 17, 2024

note: docs build is failing due to an unrelated issue which has the fix in this PR: #1737

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@balzss balzss merged commit f8cb7f0 into master Oct 18, 2024
10 of 11 checks passed
@balzss balzss deleted the chore/fix-a11y-issues-in-docs branch October 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants