fix(many): border colors are adjusted to meet a11y contrast standards #1743
Conversation
| background: componentTheme.toggleBackground, | ||
| boxShadow: componentTheme.toggleShadow, | ||
| borderRadius: '100%' | ||
| borderRadius: '100%', | ||
| border: componentTheme.borderWidth + ' solid', |
There was a problem hiding this comment.
you can write this a bit simpler:
const { borderWidth, uncheckedIconBorderColor, checkedIconBorderColor} = componentTheme
...
border: `${borderWidth} solid ${checked ? 'checkedIconBorderColor' : 'uncheckedIconBorderColor'}`,
| @@ -1377,6 +1377,10 @@ class Drilldown extends Component<DrilldownProps, DrilldownState> { | |||
| getDisabledOptionProps | |||
| }) => ( | |||
| <View | |||
| themeOverride={{ | |||
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| @@ -1418,6 +1422,9 @@ class Drilldown extends Component<DrilldownProps, DrilldownState> { | |||
| })} | |||
| > | |||
| <View | |||
| themeOverride={{ | |||
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
There was a problem hiding this comment.
I think according to our last discussion with Topi, we haven't made a conclusion that themeOverride should be used or not
| return ( | ||
| <ContextView | ||
| {...viewProps} | ||
| themeOverride={{ |
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| return ( | ||
| <View | ||
| {...viewProps} | ||
| themeOverride={{ borderColorPrimary: styles?.borderColor }} |
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| @@ -162,6 +174,7 @@ class ToggleGroup extends Component<ToggleGroupProps> { | |||
| display="block" | |||
| borderRadius="medium" | |||
| background="primary" | |||
| themeOverride={{ borderColorPrimary: styles?.borderColor }} | |||
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
Closes: INSTUI-4319
ToMESSKa
force-pushed
the
INSTUI-4319_fix_border_contrast_a_11_y_issues
branch
from
cf7f0c8
to
b560405
Compare
|
|
Can you please check where the old (low contrast) border color is used (where its not overridden by this PR)? |
Closes: INSTUI-4319
TEST PLAN: