Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Jason integration with flutter_webrtc library #10

Merged
merged 60 commits into from
Nov 10, 2021
Merged

Basic Jason integration with flutter_webrtc library #10

merged 60 commits into from
Nov 10, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 14, 2021 •
edited
Loading

Synopsis

Это PR из цикла задач по интеграции Jason'а в Flutter Android. В рамках этой задачи, были добавлены базовое взаимодействие Jason'а с flutter_webrtc.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform platform::ios Specific to iOS platform labels Oct 14, 2021
@evdokimovs evdokimovs self-assigned this Oct 14, 2021
alexlapa and others added 20 commits October 14, 2021 16:00
@alexlapa
corrections
5a5e3be
@evdokimovs
Implement CallbackListener with DartValue and add tests for it
d338997
@evdokimovs
Cleanup
005d0a5
@evdokimovs
Migrate DartFutureResolver to DartValue approach
16836b8
@evdokimovs
Impl FallibleDartFutureResolver
b57fc6d
@evdokimovs
Add docs
0f76280
@evdokimovs
Fix lints
1f068f4
@evdokimovs
Merge branch 'master' into add-platform-utils
eda516d
@evdokimovs
Fix merge
c6b339b
@evdokimovs
Reread
89bd6a8
@evdokimovs
Fix FallibleFutureResolver
aabad5d
@evdokimovs
Arg cleaning and refactoring
448dfee
@evdokimovs
Merge branch 'master' into add-basic-dart-bindings
c7d191e
@evdokimovs
Merge branch 'add-platform-utils' into add-basic-dart-bindings
33790fb 
# Conflicts:
#	src/platform/dart/utils/mod.rs
@alexlapa
Merge branch 'master' into add-platform-utils
1926754
@evdokimovs
Adapt to the new DartValue approach
415200e
@evdokimovs
Add convertation of DartValue to DartHandle
405ca8d
@evdokimovs
Refactor working with primitives with DartValue
e8fada6
@alexlapa
corrections
378878c
@evdokimovs
Add Dart side platform bindings
0135bed
@evdokimovs
Minor refactor
9a01308
@evdokimovs
Merge branch 'master' into add-basic-dart-bindings
5fe55bf 
# Conflicts:
#	flutter/lib/src/native/ffi/box_handle.dart
#	flutter/lib/src/native/ffi/callback.dart
#	flutter/lib/src/native/ffi/future.dart
#	flutter/lib/src/native/ffi/native_string.dart
#	flutter/lib/src/native/platform/functions_registerer.dart
#	flutter/lib/src/native/platform/object.dart
#	src/api/dart/mod.rs
#	src/api/dart/utils/string.rs
#	src/platform/dart/utils/callback.rs
#	src/platform/dart/utils/dart_future.rs
#	src/platform/dart/utils/handle.rs
#	src/platform/dart/utils/mod.rs
@evdokimovs
Fmt
e0f2550
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Oct 26, 2021 •
edited by tyranron
Loading

FCM

Basic Jason integration with `flutter_webrtc` library (#10)

- add bindings for `PeerConnection`, `MediaStreamTrack`, `IceCandidate` and `Transceiver`
- add ability to return `ForeignValue` from Dart without memory leaking
- add support for Dart callbacks with two arguments
- adapt internal Jason implementations for working with async `flutter_webrtc` methods

Additionally:
- use `instrumentisto/flutter-webrtc` fork instead of upstream

@evdokimovs evdokimovs marked this pull request as ready for review October 26, 2021 11:39
@evdokimovs evdokimovs requested a review from alexlapa October 26, 2021 11:45
alexlapa
alexlapa requested changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs ,

Discussed, added todos.

@evdokimovs evdokimovs requested a review from alexlapa November 8, 2021 16:01
alexlapa
alexlapa approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs ,

LGTM, передавайте tyranron'у как CI'ка докрутиться.

@evdokimovs
Copy link
Contributor Author

evdokimovs commented Nov 9, 2021 •
edited
Loading

@alexlapa , @tyranron ,

Откуда вытекает проблема с wasm-pack'ом до конца не ясно. Но проблема не на нашей стороне, поскольку тоже самое происходит при попытке билда пустой библиотеки в Docker'е. Можно посмотреть в репозитории evdokimovs/wasm-pack-segfault.

Также, закинул issue в wasm-pack: rustwasm/wasm-pack#1079

@evdokimovs evdokimovs requested a review from tyranron November 9, 2021 14:50
@evdokimovs evdokimovs changed the title Draft: Basic flutter_webrtc integration Basic Jason integration with flutter_webrtc library Nov 10, 2021
@evdokimovs evdokimovs merged commit 23ca7a5 into master Nov 10, 2021
@evdokimovs evdokimovs deleted the add-basic-dart-bindings branch November 10, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform platform::ios Specific to iOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa