Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firefox screenshare #135

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Fix firefox screenshare #135

merged 8 commits into from
Dec 6, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Oct 20, 2023 •
edited by tyranron
Loading

Synopsis

Firefox track.device_id return None for screen share.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::design Related to overall design and/or architecture platform::web Specific to WEB platform labels Oct 20, 2023
@rogurotus rogurotus self-assigned this Oct 20, 2023
@alexlapa
Merge branch 'master' into fix-firefox-screen-share
fc9744b 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	flutter/example/pubspec.lock
#	flutter/example/pubspec.yaml
#	flutter/lib/src/native/ffi/jason_api.g.dart
#	flutter/pubspec.yaml
#	flutter/test/e2e/steps/given.dart
#	flutter/test/e2e/world/member.dart
#	src/api/dart/api_bridge_generated.rs
@alexlapa
Merge branch 'master' into fix-firefox-screen-share
2361c46
@alexlapa
corrections
a9a2791
@alexlapa
changelog
8394a57
@alexlapa alexlapa marked this pull request as ready for review December 6, 2023 09:15
@alexlapa alexlapa self-requested a review December 6, 2023 09:15
@alexlapa alexlapa requested a review from tyranron December 6, 2023 10:10
@tyranron tyranron added k::refactor Refactoring, technical debt elimination and other improvements of existing code base and removed k::design Related to overall design and/or architecture labels Dec 6, 2023
@tyranron tyranron enabled auto-merge (squash) December 6, 2023 14:06
@tyranron tyranron merged commit c654848 into master Dec 6, 2023
46 of 48 checks passed
@tyranron tyranron deleted the fix-firefox-screen-share branch December 6, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogurotus @tyranron @alexlapa