Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Connection media state management (#41) #43

Merged
merged 25 commits into from
Apr 12, 2022
Merged

Implement Connection media state management (#41) #43

merged 25 commits into from
Apr 12, 2022

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Apr 5, 2022 •
edited by tyranron
Loading

Closes #41

Synopsis

Currently, Jason supports remote media disabling/enabling only for whole Room. But we need functional of the partial media disabling/enabling on the ConnectionHandle level.

This PR implements new ConnectionHandle methods:

  • ConnectionHandle.enable_remote_video
  • ConnectionHandle.disable_remote_video
  • ConnectionHandle.enable_remote_audio
  • ConnectionHandle.disable_remote_audio

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels Apr 5, 2022
@evdokimovs evdokimovs self-assigned this Apr 5, 2022
@evdokimovs
Copy link
Contributor Author

FCM

Implement `Connection` media state management (#43, #41)

@evdokimovs evdokimovs marked this pull request as ready for review April 5, 2022 17:19
@evdokimovs
Fix lint/rustfmt
0418787
@evdokimovs
Fix Flutter tests
e226523
@evdokimovs
Fix doc link
b9c6e37
@evdokimovs
Remove unrelated change
804872a
@evdokimovs
Use RecvConstraints in ConnectionHandle
8bb0716
@evdokimovs
Merge branch 'master' into add-connection-media-state-management
16fc41f 
# Conflicts:
#	flutter/android/src/main/jniLibs/arm64-v8a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/armeabi-v7a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86_64/libmedea_jason.so
#	flutter/assets/pkg/medea_jason.js
#	flutter/assets/pkg/medea_jason_bg.wasm
@evdokimovs
Rebuild
9d96d17
@evdokimovs
Minor docs improvements
57075ae
@evdokimovs
Minor fixes
8e63cfa
@evdokimovs evdokimovs requested a review from alexlapa April 6, 2022 11:30
@evdokimovs evdokimovs changed the title Draft: Implement Connection media state management (#41) Implement Connection media state management (#41) Apr 6, 2022
evdokimovs and others added 8 commits April 7, 2022 13:40
@evdokimovs
Add more E2E tests
d77e84a
@alexlapa
Merge branch 'master' into add-connection-media-state-management
bf435c6 
# Conflicts:
#	flutter/android/src/main/jniLibs/arm64-v8a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/armeabi-v7a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86_64/libmedea_jason.so
@alexlapa
corrections
e15f23f
@alexlapa
corrections
4db12fa
@logist322
Windows compile
03e0a0c
@alexlapa
Merge remote-tracking branch 'origin/add-connection-media-state-manag…
c7719ac 
…ement' into add-connection-media-state-management
@alexlapa
corrections
0749849
@alexlapa
update deps
d9bd9d3
@alexlapa alexlapa requested a review from tyranron April 11, 2022 08:02
tyranron added 2 commits April 12, 2022 16:40
@tyranron
Merge branch 'master' into add-connection-media-state-management
764fb62 
# Conflicts:
#	src/platform/dart/utils/function.rs
#	src/platform/dart/utils/handle.rs
@tyranron
Corrections
1ea0a4e
@tyranron tyranron merged commit 91d1dd7 into master Apr 12, 2022
@tyranron tyranron deleted the add-connection-media-state-management branch April 12, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ConnectionHandle.(enable|disable)_remote_(audio|video)
4 participants
@evdokimovs @tyranron @alexlapa @logist322