Add visit() function to source tree #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new visit() function: - Passes each node as an argument to the specified callable. - Decides which node to visit next based on the return type. The return types are an enum; the values in this enum may need to be extended in order to support additional functionality. Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Nov 4, 2024
Signed-off-by: John Pennycook <[email protected]>
|
The failing tests are unrelated to these changes and are caused by #120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
visit()function:The return types are an enum; the values in this enum may need to be extended in order to support additional functionality.
Related issues
Part of #101.
visit()will be used to implement replacements for the remaining classes from thewalkers/module.Proposed changes
visit()functions toNodeandSourceTree, which invoke the specified callable.Visit.NEXTandVisit.NEXT_SIBLINGbehavior.