Update code style #31
Commits on Jan 8, 2024
-
Remove undesirable pre-commit checks
We use print statements for console output, so shouldn't run flake8-print. We run black as part of pre-commit already, so don't need to run flake8-black. We can safely ignore the following flake8 checks: - S105: We don't use any passwords, so don't need to check for them. - E203: flake8 and black disagree on how to format [x : y] Signed-off-by: John Pennycook <[email protected]>
-
Add compatibility options to pre-commit hooks
black and isort both require explicit line lengths for compatibility with flake8's default length of 79 characters. isort additionally needs to be told to use black-compatible formatting. Signed-off-by: John Pennycook <[email protected]>
-
Re-order pre-commit checks to minimize passes
With the original order, it was possible for files to fail the pre-commit multiple times. For example, running black may introduce a new multi-line statement that add-trailing-comma couldn't adjust (because it ran first). The new order tries to group hooks to update: 1) Formatting-independent syntax 2) Statement order 3) Formatting 4) Formatting-dependent syntax Signed-off-by: John Pennycook <[email protected]>
-
Run new pre-commit hooks on all files
This commit enforces the new formatting, but does nothing to address any of the errors raised by the new linter. Signed-off-by: John Pennycook <[email protected]>
-
Remove imported but unused modules
F401 Signed-off-by: John Pennycook <[email protected]>
-
Rename variables with ambiguous names
E741 Signed-off-by: John Pennycook <[email protected]>
-
Fix f-string with missing placeholders
F541 Signed-off-by: John Pennycook <[email protected]>
-
Fix reference to undefined name "ParserError"
F821 Signed-off-by: John Pennycook <[email protected]>
-
Move module level imports to top of file
E402 Signed-off-by: John Pennycook <[email protected]>
-
Use isinstance instead of comparing types
E721 Signed-off-by: John Pennycook <[email protected]>
-
Replace '%' operator with f-strings
FS001 Signed-off-by: John Pennycook <[email protected]>
-
Replace usage of '.format' with f-strings
FS002 Signed-off-by: John Pennycook <[email protected]>
-
Manually wrap some lines to 79 characters
E501 Signed-off-by: John Pennycook <[email protected]>
-
Remove comments used to disable old hooks
Signed-off-by: John Pennycook <[email protected]>
-
Signed-off-by: John Pennycook <[email protected]>
-
Ignore F401 in __init__.py files
F401 is 'Module imported but unused'. Ignoring F401 for all __init__.py files seems like a cleaner solution than introducing unnecessary references to the modules (e.g. via __all__ or similar). Signed-off-by: John Pennycook <[email protected]>
-
Use matplotlib functions consistently
Signed-off-by: John Pennycook <[email protected]>
