Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pull request template formatting #48

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Pennycook
Copy link
Contributor

Moves the instructions into comments. This will prevent instructions from being included in created pull requests (unless somebody uncomments them), and gives us the freedom to expand upon the instructions (e.g., by including links).

Related issues

N/A

Proposed changes

  • Make PR template instructions into comments.
  • Add a link to the GitHub documentation for closing keywords.
  • Remove the — to make the comments human-readable (since we're not going to display them anywhere).

Moves the instructions into comments. This will prevent instructions from being
included in created pull requests (unless somebody uncomments them), and gives
us the freedom to expand upon the instructions (e.g., by including links).

Signed-off-by: John Pennycook <[email protected]>
@Pennycook Pennycook added the documentation Improvements or additions to documentation label Feb 6, 2024
Copy link
Contributor

@laserkelvin laserkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pennycook Pennycook merged commit fccb213 into intel:main Feb 6, 2024
1 check passed
@Pennycook Pennycook deleted the pr-template branch February 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants