Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all deprecation warnings DeprecationWarnings #69

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Pennycook
Copy link
Contributor

Related issues

N/A

Proposed changes

  • Add DeprecationWarning to deprecation warnings that defaulted to UserWarning.

@laserkelvin: I'm really sorry about this one. I keep forgetting what warnings.warn defaults to.

@Pennycook Pennycook added the bug Something isn't working label Feb 29, 2024
@Pennycook Pennycook added this to the 1.2.0 milestone Feb 29, 2024
Copy link
Contributor

@laserkelvin laserkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pennycook Pennycook merged commit 87cbffd into intel:main Mar 1, 2024
2 checks passed
@Pennycook Pennycook deleted the fix-deprecation-warnings branch March 1, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants