Remove YAML configuration files #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously deprecated in 1.2.0. Signed-off-by: John Pennycook <[email protected]>
Previously, an analysis file was optional because legacy behavior allowed for an implicit YAML configuration file called "config.yaml" in the current directory. Signed-off-by: John Pennycook <[email protected]>
This was only used to determine a project name from the YAML configuration file. Output file names for TOML configuration files are derived differently. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Apr 22, 2024
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Part of the fix for #87.
Proposed changes
--configoption and checks for an implicit YAML configuration file.Note that although the test diffs look big, in many cases this is because touching them triggered the CI checks. Some of the changes to each test are purely formatting. To try and make things simpler to review, I've put all the tests in separate commits.
I also want to draw your attention to the significant amount of bloat that now exists in the tests, with the setup for the
codebaseandconfigurationdictionaries that gets repeated in a few places. This was the most expedient way to rewrite the tests to remove the dependency on YAML functionality.The long-term fix that I have planned here is to introduce a new
CodeBaseobject representing the files in the code base, and to replace the configuration objects entirely by driving things directly from aCompilationDatabaseinstance. This is a first step towards that, to make sure that everything still works before the refactoring begins.