Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][IR] Add easy-builder to simplify IR building in C++ #52

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Menooker
Copy link

@Menooker Menooker commented May 9, 2024

@Menooker
Copy link
Author

Menooker commented May 9, 2024

This PR is currently for preview, due to pending #50 and #51

@Menooker
Copy link
Author

Menooker commented May 9, 2024

The preview upstream PR at Menooker/llvm-project#2 . It has not been submitted to upstream MLIR and is only in my fork, for now.

}

#define DEF_EASYBUILD_CMP_OPERATOR(OP, OPCLASS, TYPE, PRED) \
EBUnsigned operator OP(const TYPE &a, const TYPE &b) { \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an inline here (also commented on the upstream preparation repo, sorry for spam~)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not spam! Thanks for finding that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants