Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] sycl-ls change to allow detection of specific PVC type #15689

Open
wants to merge 9 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] sycl-ls change to allow detection of specific PVC type #15689

wants to merge 9 commits into from
+26 −8

Conversation

DYNIO-INTEL
Copy link
Contributor

@DYNIO-INTEL DYNIO-INTEL commented Oct 14, 2024 •
edited
Loading

The purpose of this change is to allow to mark with // XFAIL: gpu-intel-pvc-1T tests that are still failing exclusively on PVC T1.
In this change, new information about the device_id was added to sycl-ls --verbose if device id is available.

@DYNIO-INTEL DYNIO-INTEL changed the title [SYCL] Skip failing tests for PVC T1 [SYCL] sycl-ls change to allow detect PVC T1 Oct 15, 2024
@DYNIO-INTEL DYNIO-INTEL changed the title [SYCL] sycl-ls change to allow detect PVC T1 [SYCL] sycl-ls change to allow detect specific PVC type Oct 15, 2024
@DYNIO-INTEL DYNIO-INTEL changed the title [SYCL] sycl-ls change to allow detect specific PVC type [SYCL] sycl-ls change to allow detection of specific PVC type Oct 15, 2024
@DYNIO-INTEL DYNIO-INTEL marked this pull request as ready for review October 15, 2024 08:51
@DYNIO-INTEL DYNIO-INTEL requested review from a team as code owners October 15, 2024 08:51
maarquitos14
maarquitos14 reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add gpu-intel-pvc-2T?

sycl/test-e2e/lit.cfg.py Outdated Show resolved Hide resolved
@DYNIO-INTEL
Copy link
Contributor Author

Should we also add gpu-intel-pvc-2T?

I added just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@aarongreig aarongreig aarongreig approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DYNIO-INTEL @AlexeySachkov @maarquitos14 @aarongreig