Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][COMPAT] Add one helper function get_local_mem_size() to get local memory size #15695

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][COMPAT] Add one helper function get_local_mem_size() to get local memory size #15695

wants to merge 2 commits into from
+5 −0

Conversation

tomflinda
Copy link
Contributor

Signed-off-by: chenwei.sun [email protected]

@tomflinda tomflinda requested a review from a team as a code owner October 15, 2024 02:50
@tomflinda tomflinda mentioned this pull request Oct 15, 2024
Open
Alcpz
Alcpz requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the signature to the documentation?

@tomflinda
Copy link
Contributor Author

tomflinda commented Oct 15, 2024 •
edited
Loading

Can you add the signature to the documentation?

Done in the latest commit.

@tomflinda
Address review comment
21b7562 
Signed-off-by: chenwei.sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcpz Alcpz Alcpz requested changes

@zhimingwang36 zhimingwang36 zhimingwang36 approved these changes

@zhiweij1 zhiweij1 zhiweij1 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomflinda @Alcpz @zhimingwang36 @zhiweij1