Extend XeTile.tile to support scatter load (experimental) #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jianhui-Li
changed the title
Jianhui-Li
changed the title
Garra1980
reviewed
Aug 19, 2024
docs/rfcs/XeTile.md
Outdated
| @@ -208,6 +207,22 @@ With the data being presented as 4D vector, all the vector based XeTile operatio | |||
| ``` | |||
| The tile_pack and tile_unpack operation is similar to pack and unpack operation of tensor dialect. The source vector must be a 2D dimension vector, and no permutation is allowed for the result 4D vector, so effectively the blocking effect is identical to tensor pack/unpack operation with inner_dims_pos = [0,1] inner_dims_pos = [0, 1]. | |||
|
|
|||
| ## support for load_gather and store_scatter (experimental) | |||
| `load_gather` (aka. load) load data with each element's address being explictly specified. The tile is created with a base address and offset for each element to be load. The result tile has a `scatter` attribute to different it from the regular tile. | |||
Garra1980
reviewed
Aug 19, 2024
docs/rfcs/XeTile.md
Outdated
| %tile0 = XeTile.init_tile %base_addr, %tile_offsets: | ||
| i64, vector<1x256xi32> into tile<1x256xbf16, #scatter> | ||
| ``` | ||
| `load_gather` (aka. load) load data with prepared tile and mask. Attribute `padding` specifies the padding value for the out-of-boundary access. The default value is zero. |
Garra1980
reviewed
Oct 4, 2024
docs/rfcs/XeTile.md
Outdated
| @@ -208,6 +207,22 @@ With the data being presented as 4D vector, all the vector based XeTile operatio | |||
| ``` | |||
| The tile_pack and tile_unpack operation is similar to pack and unpack operation of tensor dialect. The source vector must be a 2D dimension vector, and no permutation is allowed for the result 4D vector, so effectively the blocking effect is identical to tensor pack/unpack operation with inner_dims_pos = [0,1] inner_dims_pos = [0, 1]. | |||
|
|
|||
| ## support for load_gather and store_scatter (experimental) | |||
| `load_gather` (aka. load) loads data with each element's address being explictly specified. The tile is created with a base address and offset for each element to be load. The result tile has a `scatter` attribute to different it from the regular tile. | |||
There was a problem hiding this comment.
different - > distinguish?
"to be load" - > "to be loaded"
Garra1980
reviewed
Oct 4, 2024
docs/rfcs/XeTile.md
Outdated
| ## support for load_gather and store_scatter (experimental) | ||
| `load_gather` (aka. load) loads data with each element's address being explictly specified. The tile is created with a base address and offset for each element to be load. The result tile has a `scatter` attribute to different it from the regular tile. | ||
| ```mlir | ||
| %tile0 = XeTile.init_tile %base_addr, %tile_offsets: |
There was a problem hiding this comment.
XeTile->xetile here and below since it is a name for dialect operation
|
@chencha3 pls take a look, do you think this is enough for now? |
change XeTile. to xetile. in the code example
Garra1980
approved these changes
Oct 4, 2024
|
let's merge after conflicts resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review these guidelines to help with the review process: