Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: increase threshold for memory usage on tests #2108

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Oct 14, 2024

Description

ref #2107

This PR increases the threshold for the tests that check for memory usage increases to 25% of the input data size, as those tests were previously producing failures on some CI runs in that other PR.

Regardless of whether there are or aren't any memory leaks, it is not guaranteed that this condition would be met, since a memory allocator is not required to return all memory to the OS after freeing it, but this increase should allow the CI jobs to pass until a better solution is found.

Note that the PR contains an unrelated change - this is coming from the precommit hook, which required that change to go into the PR.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@david-cortes-intel david-cortes-intel added the testing Tests for sklearnex/daal4py/onedal4py & patching sklearn label Oct 14, 2024
Copy link
Contributor

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to use this specific value for specific cases

@david-cortes-intel
Copy link
Contributor Author

I think better to use this specific value for specific cases

Changed it use 25% for pandas inputs, while leaving it at 15% for other types of inputs.

@Alexsandruss Alexsandruss marked this pull request as draft October 14, 2024 09:43
@Alexsandruss
Copy link
Contributor

Check PR Checklist / Close all checkboxes before moving from draft

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel david-cortes-intel marked this pull request as ready for review October 15, 2024 07:45
Copy link
Contributor

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Assuming green internal CI as well.
For me make sense also cover with ticket further investigation the reason of such number increase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tests for sklearnex/daal4py/onedal4py & patching sklearn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants