-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: increase threshold for memory usage on tests #2108
base: main
Are you sure you want to change the base?
TEST: increase threshold for memory usage on tests #2108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think better to use this specific value for specific cases
Changed it use 25% for pandas inputs, while leaving it at 15% for other types of inputs. |
|
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Assuming green internal CI as well.
For me make sense also cover with ticket further investigation the reason of such number increase
Description
ref #2107
This PR increases the threshold for the tests that check for memory usage increases to 25% of the input data size, as those tests were previously producing failures on some CI runs in that other PR.
Regardless of whether there are or aren't any memory leaks, it is not guaranteed that this condition would be met, since a memory allocator is not required to return all memory to the OS after freeing it, but this increase should allow the CI jobs to pass until a better solution is found.
Note that the PR contains an unrelated change - this is coming from the precommit hook, which required that change to go into the PR.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance