-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI, enhancement] enable external oneDAL builds in build-and-test-lnx.yml Azure Pipelines #2125
Open
icfaust
wants to merge
41
commits into
intel:main
Choose a base branch
from
icfaust:dev/azure_pipelines_without_dal-devel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
c1318ff
Update build-and-test-lnx.yml
icfaust aa42262
Update build-and-test-lnx.yml
icfaust 2558b9d
Update build-and-test-lnx.yml
icfaust ed24588
Update build-and-test-lnx.yml
icfaust 4be72c8
Update build.sh
icfaust 97c7257
Update run_test.sh
icfaust 30f5583
Update build-and-test-lnx.yml
icfaust 0391a2f
Update run_test.sh
icfaust a0c0634
Update build-and-test-lnx.yml
icfaust fc34815
Update ci.yml
icfaust 47e8e30
Update ci.yml
icfaust 9e9ce4f
Update build.sh
icfaust 5f2f414
Update build.sh
icfaust 626a9c5
Update build-and-test-lnx.yml
icfaust a75001e
Update run_test.sh
icfaust 0492649
Update build-and-test-lnx.yml
icfaust 72f4ddb
Update build-and-test-lnx.yml
icfaust d5ddbb1
Update build-and-test-lnx.yml
icfaust 98e6615
Update build-and-test-lnx.yml
icfaust a777cb3
Update build-and-test-lnx.yml
icfaust 8bf074d
Update build-and-test-lnx.yml
icfaust ad94c40
Merge branch 'intel:main' into dev/azure_pipelines_without_dal-devel
icfaust 19f88ab
Update build-and-test-lnx.yml
icfaust 2b165c3
Merge branch 'intel:main' into dev/azure_pipelines_without_dal-devel
icfaust b9cf707
Merge branch 'intel:main' into dev/azure_pipelines_without_dal-devel
icfaust 8929fc3
add TBBROOT and disable dpnp/dpctl by NO_DPC
icfaust 069a3f1
Update build-and-test-lnx.yml
icfaust bd939f9
Update build-and-test-lnx.yml
icfaust 163ffbc
Update build-and-test-lnx.yml
icfaust 6b1c7e4
Update build-and-test-lnx.yml
icfaust ef4b81b
Update build-and-test-lnx.yml
icfaust 763c1e6
Update setup.py
icfaust e4c481d
Update setup.py
icfaust 72adc22
Update build-and-test-lnx.yml
icfaust b7b3b35
Update ci.yml
icfaust 01354d9
Update ci.yml
icfaust 01f2b31
Update build-and-test-lnx.yml
icfaust 6fe5e0f
Update build-and-test-lnx.yml
icfaust 8af396c
Merge branch 'intel:main' into dev/azure_pipelines_without_dal-devel
icfaust 38da718
Update build-and-test-lnx.yml
icfaust d57cf5d
Update build-and-test-lnx.yml
icfaust File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: would this switch all of these jobs to the external builds? I think it'd be quite useful to leave some with the stable release too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good question and suggestion. Why do we stop using stable version for building and testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will switch to external builds only if a DALROOT is specified, and example using it is here: oneapi-src/oneDAL#2950 which is the immediate use case. The question remains the same as when GitHub actions CI was introduced, do we eventually want to move toward using versions of oneDAL main branch rather than release branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icfaust I think it would be good to get @homksei @Alexsandruss @napetrov and @syakov-intel ’s opinions on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samir-nasibli Just as a note, there is a precedence within the conda-recipe for DPCPPROOT set outside of the conda-recipe: https://github.com/intel/scikit-learn-intelex/blob/main/conda-recipe/build.sh#L38
This work simply continues on that precedent.
Secondly, the core flow using stable versions for building and testing on azure pipelines CI is not changed. Dal-devel and oneapi components are still acquired from conda in azure pipelines.