Uptading cubes to python 3 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix BUG DataBrewery#370 by getting fact table key column defined in StarSchema
* Add if conditional expression
`cubes.metadata.*` is added to `cubes.metadata` because the validate_model was previously a function part of it (ascendance compatibility). Then, it impacts necessarily the new import added to `cubes.slicer.commands`. In the function `cubes.slicer.commands`, the packages `cubes` and `cubes.providers` are no longer available, the link to the owned functions are so rebuild.
…cer_validate_model Fix import regression which prevent from unsing the command `slicer model validate`.
…ewery#461) The values returned by `OrderedDict.values()` is an instance of a class that cannot be copied in py3k (a list in python 2). For this reason, the following message appears : > TypeError: can't pickle odict_values objects The solution is to first copy the `OrderedDict` and then get the iterator on his values.
* Add new test to check that the Workspace handle correctly the input parameter * Refactor the code to use a single function to parse the configuration. The config parser should be placed in a independent module to avoid the mutual import issues.
Malformed example json fix.
* Updated doc with fix of importing slicer.ini and typos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.