Fix the issue that len(indices) and num_samples might not be equal #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en importing a checkpoint to resume training
sunjq1
requested review from
workingloong,
samplise,
BalaBalaYi and
majieyue
as code owners
BalaBalaYi
requested changes
Nov 19, 2024
since I adjusted the logic for splitting indices after loading the checkpoint, I corrected the num values in the UT file |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
- Coverage 80.48% 79.82% -0.66%
==========================================
Files 219 240 +21
Lines 20208 22578 +2370
==========================================
+ Hits 16264 18023 +1759
- Misses 3944 4555 +611 ☔ View full report in Codecov by Sentry. |
|
@BalaBalaYi Hi，the submitted code format optimization has been completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modified the definition of
total_sizein theload_state_dictfunction and the definition ofindicesin the__iter__function to ensure thatassert len(indices) == self.num_samples.Why are the changes needed?
In the previous ElasticDistributedSampler code, the issue where
completed_numnot being divisible bynum_replicascould cause anAssertionErrorin the scenario of importing a checkpoint was not considered.Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT and training test.