refactor: separate faucet funding from validation #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <[email protected]>
|
This change in isolation will break the funding process, so I don't think it's a good idea to merge without having the vault side ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill [email protected]
We saw a number of timeouts on testnet when vaults were waiting for the faucet to respond. This change allows the faucet to respond immediately if the funding request is valid and then spawns a separate task to submit and watch the transaction(s). My plan was to batch and return the extrinsic hash to subscribe in the vault client but that is not possible (paritytech/subxt#559). My proposed next step is to simply retry registration if the client does not have sufficient funds or we could wait for the account to have sufficient funds before continuing.