fix: save rescanning progress #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
force-pushed
the
fix/save-rescanning-progress
branch
from
90ba3dc to
520ca00
Compare
gregdhill
reviewed
May 23, 2023
Comment on lines
+134
to
+139
| let _vault_id_manager = VaultIdManager::from_map( | ||
| new_vault_provider.clone(), | ||
| new_btc_rpc_master_wallet, | ||
| btc_rpcs, | ||
| "test_replace_succeeds1", | ||
| ); |
There was a problem hiding this comment.
Doesn't look like we need this, or is the construction required?
There was a problem hiding this comment.
It's just to ensure that tests don't interfere with each other by reading eath other's databases. We could use something like tempdir but I think for now this is fine
sander2
force-pushed
the
fix/save-rescanning-progress
branch
from
520ca00 to
d1402d6
Compare
sander2
force-pushed
the
fix/save-rescanning-progress
branch
from
d1402d6 to
bba8a70
Compare
sander2
force-pushed
the
fix/save-rescanning-progress
branch
from
bba8a70 to
c8538f1
Compare
gregdhill
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #471 .
Note that I went with another approach - rather than storing data in a hacky way inside the bitcoin wallet, I store it in a rocksdb (since we'll be stateful anyway with #246). I wrote it in such a way that the database can be removed without any bad side-effects: it will just rescan everything again. This means that users don't necessarily have to copy over the database when migrating their vaults to other servers