-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade bitcoin rpc dependency #490
chore: upgrade bitcoin rpc dependency #490
Conversation
96ff778
to
59b771d
Compare
fb8b227
to
758cba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor nits, otherwise LGTM
@@ -215,7 +216,7 @@ impl ElectrsClient { | |||
let txid = self | |||
.cli | |||
.post(url) | |||
.body(serialize(&tx).to_hex()) | |||
.body(hex::encode(serialize(&tx))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to ToHex
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was giving me errors, I think because upstream made some changes, see rust-bitcoin/rust-bitcoincore-rpc#88
}?; | ||
let script_code = prev_out | ||
.script_pubkey | ||
.p2wpkh_script_code() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have this implemented for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea the bitcoin crate has a lot of utilities, there is probably more code we can replace, but I wanted to keep the pr as minimal as possible
758cba2
to
b7e4f64
Compare
b7e4f64
to
8439892
Compare
No description provided.