chore: upgrade bitcoin rpc dependency #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
force-pushed
the
chore/upgrade-bitcoincore-rpc
branch
4 times, most recently
from
96ff778
to
59b771d
Compare
sander2
force-pushed
the
chore/upgrade-bitcoincore-rpc
branch
4 times, most recently
from
fb8b227
to
758cba2
Compare
gregdhill
approved these changes
Jul 21, 2023
| @@ -215,7 +216,7 @@ impl ElectrsClient { | |||
| let txid = self | |||
| .cli | |||
| .post(url) | |||
| .body(serialize(&tx).to_hex()) | |||
| .body(hex::encode(serialize(&tx))) | |||
There was a problem hiding this comment.
It was giving me errors, I think because upstream made some changes, see rust-bitcoin/rust-bitcoincore-rpc#88
| }?; | ||
| let script_code = prev_out | ||
| .script_pubkey | ||
| .p2wpkh_script_code() |
There was a problem hiding this comment.
Nice to have this implemented for us
There was a problem hiding this comment.
Yea the bitcoin crate has a lot of utilities, there is probably more code we can replace, but I wanted to keep the pr as minimal as possible
sander2
force-pushed
the
chore/upgrade-bitcoincore-rpc
branch
from
758cba2
to
b7e4f64
Compare
sander2
force-pushed
the
chore/upgrade-bitcoincore-rpc
branch
from
b7e4f64
to
8439892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.