-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge currency specific bitcoin wallets #494
Conversation
5120ee5
to
388d744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit worried about the fact that all vaults will now use the same rpc connection - specifically of concurrent access. I think that it'll be mostly ok, since we already were using the connection from multiple tasks, and we have the locking in place for tx creation. But please also have a think about it
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
ea2a45b
to
9406775
Compare
Signed-off-by: Gregory Hill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it's a relatively high-risk pr, so we should definitely test this on testnet
tracing::info!("initial status: = {scanning_status:?}"); | ||
let account_id = btc_parachain.get_account_id(); | ||
let mut scanning_status = RescanStatus::get(&account_id, db)?; | ||
tracing::info!("Scanning: {scanning_status:?}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite accurate since scanning range is updated below based on issues
Closes #484
Adds a new bitcoin wallet with the suffix "shared" and migrates all keys from the currency specific wallets. I went back and forth a bit on the metrics but I added a second commit which merges those that make sense. If we revert that commit the metrics are duplicated for each vault label.