feat(telemetry): plural on OPEN_TELEMETRY_COLLECTOR_URLS

& docs changes
interledger · Feb 22, 2024 · 8135aac · 8135aac
1 parent 1c759e3
commit 8135aac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/backend/src/config/app.ts b/packages/backend/src/config/app.ts
@@ -40,7 +40,7 @@ export const Config = {
   enableTelemetry: envBool('ENABLE_TELEMETRY', true),
   livenet: envBool('LIVENET', false),
   openTelemetryCollectors: envStringArray(
-    'OPEN_TELEMETRY_COLLECTOR_URL',
+    'OPEN_TELEMETRY_COLLECTOR_URLS',
     process.env.LIVENET
       ? []
       : [

diff --git a/packages/documentation/src/content/docs/telemetry/integrating.md b/packages/documentation/src/content/docs/telemetry/integrating.md
@@ -9,8 +9,8 @@ In order to do so, the integrating ASE must deploy its own OpenTelemetry collect
 ## Rafiki Telemetry Environment Variables
 
 - `ENABLE_TELEMETRY`: boolean, defaults to `true`. Enables the telemetry service on Rafiki.
-- `LIVENET`: boolean. Should be set to `true` on production environments. If it is not set, it will default to `false`, and metrics will get sent to the testnet otel-collector
-- `OPEN_TELEMETRY_COLLECTOR_URL`: CSV of URLs for Open Telemetry collectors (e.g., `http://otel-collector-NLB-e3172ff9d2f4bc8a.elb.eu-west-2.amazonaws.com:4317,http://happy-life-otel-collector:4317`).
+- `LIVENET`: boolean. Should be set to `true` on production environments dealing with real money. If it is not set, it will default to `false`, and metrics will get sent to the testnet otel-collector
+- `OPEN_TELEMETRY_COLLECTOR_URLS`: CSV of URLs for Open Telemetry collectors (e.g., `http://otel-collector-NLB-e3172ff9d2f4bc8a.elb.eu-west-2.amazonaws.com:4317,http://happy-life-otel-collector:4317`).
 - `OPEN_TELEMETRY_EXPORT_INTERVAL`: number in milliseconds, defaults to `15000`. Defines how often the instrumented Rafiki instance should send metrics.
 - `TELEMETRY_EXCHANGE_RATES_URL`: string URL, defaults to `https://telemetry-exchange-rates.s3.amazonaws.com/exchange-rates-usd.json`. It defines the endpoint that Rafiki will query for exchange rates, as a fallback when ASE does not [provide them](/integration/getting-started/#exchange-rates). If set, the response format of the external exchange rates API should be of type Rates, as the rates service expects.
   The default endpoint set here points to a public S3 that has the previously mentioned required format, updated daily.