fix(auth): session cookie not expiring in browser

interledger · Aug 6, 2024 · b1f9248 · b1f9248
1 parent 22e5858
commit b1f9248
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 21 deletions.
diff --git a/packages/auth/src/app.ts b/packages/auth/src/app.ts
@@ -353,24 +353,22 @@ export class App {
           signed: true,
           store: {
             async get(key) {
-              const s = await redis.hgetall(key)
-              const session = {
-                nonce: s.nonce,
-                _expire: Number(s._expire),
-                _maxAge: Number(s._maxAge)
-              }
-              return session
+              const s = await redis.get(key)
+
+              if (!s) return null
+
+              return JSON.parse(s)
             },
             async set(key, session) {
               // Add a delay to cookie age to ensure redis record expires after cookie
               const expireInMs = maxAgeMs + 10 * 1000
               const op = redis.multi()
-              op.hset(key, session)
+              op.set(key, JSON.stringify(session))
               op.expire(key, expireInMs)
               await op.exec()
             },
             async destroy(key) {
-              await redis.hdel(key)
+              await redis.del(key)
             }
           }
         },
@@ -447,17 +445,6 @@ export class App {
 
     koa.use(cors())
     koa.keys = [this.config.cookieKey]
-    koa.use(
-      session(
-        {
-          key: 'sessionId',
-          maxAge: 60 * 1000,
-          signed: true
-        },
-        koa
-      )
-    )
-
     koa.use(router.middleware())
     koa.use(router.routes())
 

diff --git a/packages/auth/src/interaction/routes.ts b/packages/auth/src/interaction/routes.ts
@@ -181,7 +181,6 @@ async function startInteraction(
 
   const trx = await Interaction.startTransaction()
   try {
-    // TODO: also establish session in redis with short expiry
     await grantService.markPending(interaction.id, trx)
     await trx.commit()