-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @adonisjs/fold to v10 - autoclosed #2334
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
@@ -28,13 +28,13 @@ describe('Wallet Address Keys Routes', (): void => { | |||
deps = await initIocContainer(Config) | |||
deps.bind('messageProducer', async () => mockMessageProducer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anybody know why we need this binding? That's why it doesn't build right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like its safe to remove, it's not used anywhere
@@ -24,7 +24,7 @@ describe('Wallet Address Key Service', (): void => { | |||
deps = await initIocContainer(Config) | |||
deps.bind('messageProducer', async () => mockMessageProducer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. These are the only 2 places we have that.
@sabineschaller this package is now ESM only, and as a results it breaks our tests: FAIL backend packages/backend/src/open_payments/wallet_address/key/routes.test.ts
● Test suite failed to run
Jest encountered an unexpected token
Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.
Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.
By default "node_modules" folder is ignored by transformers.
Here's what you can do:
• If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
• If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
• To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
• If you need a custom transformation specify a "transform" option in your config.
• If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.
You'll find more details and examples of these config options in the docs:
https://jestjs.io/docs/configuration
For information about custom transformations, see:
https://jestjs.io/docs/code-transformation
Details:
/Users/max/interledger/rafiki/node_modules/.pnpm/@[email protected]/node_modules/@adonisjs/fold/build/index.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import {
^^^^^^
SyntaxError: Cannot use import statement outside a module
24 | import { createAccountingService as createTigerbeetleAccountingService } from './accounting/tigerbeetle/service'
25 | import { createAccountingService as createPsqlAccountingService } from './accounting/psql/service'
> 26 | import { createPeerService } from './payment-method/ilp/peer/service'
| ^
27 | import { createAuthServerService } from './open_payments/authServer/service'
28 | import { createGrantService } from './open_payments/grant/service'
29 | import { createSPSPRoutes } from './payment-method/ilp/spsp/routes'
at Runtime.createScriptFromCode (node_modules/.pnpm/[email protected]/node_modules/jest-runtime/build/index.js:1505:14)
at Object.<anonymous> (packages/backend/src/index.ts:26:15)
at Object.<anonymous> (packages/backend/src/tests/app.ts:26:11)
at Object.<anonymous> (packages/backend/src/open_payments/wallet_address/key/routes.test.ts:9:14)
Test Suites: 1 failed, 1 total
Tests: 0 total
Snapshots: 0 total
Time: 0.812 s I'm guessing this is the first ESM only package that is included in backend and as a combination of jest, and swc/jest, I didn't find a working way to support this package upgrade while keeping commonjs in our project. Probably worth a discussion on this. Some related links: https://jestjs.io/docs/configuration#transformignorepatterns-arraystring |
@mkurapov thank you for pointing that out. I was so preoccupied with getting it to build that I didn't notice that. I think we should put it on the planning call agenda. What do you think? |
1f8f28d
to
678e831
Compare
6ab0fa5
to
db50963
Compare
db50963
to
d0db26e
Compare
This PR contains the following updates:
^8.2.0
->^10.1.0
Release Notes
adonisjs/fold (@adonisjs/fold)
v10.1.0
: Support import.meta.hotCompare Source
Changes
We have a cache system for the Module Importer and Module Expressions to avoid re-importing the same file several times.
Now, if ever
import.meta.hot
is defined, then this cache will not be used and the file constantly re-imported, allowing the use of Hot module reloading libraries like Hot-Hook. See https://github.com/adonisjs/fold/pull/62Commits
468df8f
)e67f821
)4efabc8
)bfe649e
)v10.0.1
: Update dependenciesCompare Source
b05e127
Full Changelog: adonisjs/fold@v10.0.0...v10.0.1
v10.0.0
: Stable major releaseCompare Source
Please consult the following releases to learn about the breaking changes between
@adonisjs/fold@8
and@adonisjs/fold@10
.Commits
d5687ac
fff013d
e644b11
838769b
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.