Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): add cors for open payments server #2438

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat(backend): add cors for open payments server #2438

merged 1 commit into from
Feb 23, 2024

Conversation

raducristianpopa
Copy link
Member

Changes proposed in this pull request

  • Add CORS for backend's open payments server

Context

Closes #2436.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Postman collection updated

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 9a2b0b7
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/65d6442ad5e52600092c27bf

njlie
njlie approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raducristianpopa raducristianpopa merged commit 249a4e6 into main Feb 23, 2024
22 checks passed
@raducristianpopa raducristianpopa deleted the rp--backend-cors branch February 23, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlie njlie njlie approved these changes

@mkurapov mkurapov mkurapov approved these changes

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add @koa/cors to backend's open payments server
3 participants
@raducristianpopa @mkurapov @njlie