fix: add node_env env var to frontend #2609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
|
@BlairCurrey I also opened up PR in helm-charts repo to add nodeEnv variable in helm charts (exactly the same way as it is for backend and auth) so that we can specify this in values.yaml file when deploying helm. |
|
To be perfectly honest, this is not needed, since default value is set to production in helm-charts repository. I suppose that we can just close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
productionnodeEnvto frontendContext
fixes #2592
Depends on
interledger/helm-charts#27interledger/helm-charts#35 Will need to merge that first.Checklist
fixes #number