-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend)!: update env variables #2732
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: backend
Changes in the backend package.
type: source
Changes business logic
labels
May 21, 2024
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
golobitch
force-pushed
the
feature/backend-env-vars
branch
from
May 21, 2024 19:15
44cbda3
to
a617edd
Compare
golobitch
force-pushed
the
feature/backend-env-vars
branch
from
May 21, 2024 19:22
a617edd
to
a9599d0
Compare
mkurapov
reviewed
May 27, 2024
@@ -32,6 +33,7 @@ services: | |||
AUTH_SERVER_INTROSPECTION_URL: http://cloud-nine-wallet-test-auth:3107 | |||
AUTH_SERVER_GRANT_URL: http://cloud-nine-wallet-test-auth:3106 | |||
ILP_ADDRESS: test.cloud-nine-wallet-test | |||
ILP_CONNECTOR_ADDRESS: http://127.0.0.1:3102 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be?
Suggested change
ILP_CONNECTOR_ADDRESS: http://127.0.0.1:3102 | |
ILP_CONNECTOR_ADDRESS: http://host.docker.internal:3102 |
* feat(auth)!: remove default values for cookie key and identity server secret * feat(auth)!: rename auth server domain to auth server url * test(integration): update env * feat(localenv): update auth env * feat(localenv): update identity server url * test(integration): update identity server url * feat(auth)!: rename identity server domain to server url * docs(integration): update deployment env variables * fix(documentation): auth env grammatical error Co-authored-by: Nathan Lie <[email protected]> --------- Co-authored-by: Nathan Lie <[email protected]>
* feat(2712): make use of backend accounting service. * feat(2712): make use of backend accounting service. * feat(2712): introduce BasicAccountingService. * feat(2712): formatting. * feat(2712): formatting. * feat(2712): remove the BaseAccountingService. * feat(2712): address warnings. * feat(2712): review comments.
github-actions
bot
added
pkg: auth
Changes in the GNAP auth package.
pkg: documentation
Changes in the documentation package.
type: documentation
(archived) Improvements or additions to documentation
labels
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: auth
Changes in the GNAP auth package.
pkg: backend
Changes in the backend package.
pkg: documentation
Changes in the documentation package.
type: documentation
(archived) Improvements or additions to documentation
type: source
Changes business logic
type: tests
Testing related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
fixes #2684
Checklist
fixes #number