Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend)!: update and rename env variables #2749

Merged
merged 15 commits into from
Jun 25, 2024
Merged

feat(backend)!: update and rename env variables #2749

merged 15 commits into from
Jun 25, 2024

Conversation

golobitch
Copy link
Collaborator

@golobitch golobitch commented May 28, 2024 •
edited
Loading

Changes proposed in this pull request

  • update default values of some env variables
  • rename env variable for enabling SPS
  • update documentation

Context

fixes #2684

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels May 28, 2024
@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 9adfdd4
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/667a7e7f7ae85700082281bd
😎 Deploy Preview https://deploy-preview-2749--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sabineschaller sabineschaller added the breaking Issue/PR that introduces breaking changes label May 29, 2024
@golobitch golobitch changed the title Feature/backend default vars feat(backend)!: update and rename env variables May 31, 2024
@golobitch golobitch force-pushed the feature/backend-default-vars branch 2 times, most recently from 31480cb to 9ceab1f Compare June 7, 2024 19:20
@github-actions github-actions bot added pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Jun 7, 2024
@golobitch golobitch force-pushed the feature/backend-default-vars branch 4 times, most recently from b49df12 to 801e6c7 Compare June 8, 2024 11:01
@golobitch golobitch marked this pull request as ready for review June 8, 2024 11:25
@golobitch golobitch self-assigned this Jun 8, 2024
@golobitch golobitch force-pushed the feature/backend-default-vars branch 3 times, most recently from d71a8f0 to 9bb13be Compare June 16, 2024 17:44
@golobitch golobitch requested a review from mkurapov June 17, 2024 07:25
@BlairCurrey BlairCurrey mentioned this pull request Jun 17, 2024
Merged
5 tasks
@golobitch golobitch force-pushed the feature/backend-default-vars branch from 8e0bdf1 to 020b79d Compare June 24, 2024 18:35
@golobitch golobitch requested a review from mkurapov June 24, 2024 19:13
@golobitch golobitch merged commit d5c7860 into main Jun 25, 2024
42 checks passed
@golobitch golobitch deleted the feature/backend-default-vars branch June 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees

@golobitch golobitch

Labels
breaking Issue/PR that introduces breaking changes pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[backend] update env vars and remove defaults
3 participants
@golobitch @mkurapov @sabineschaller