chore(auth): return objects during GNAP errors #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
commented
Jun 21, 2024
| @@ -57,10 +57,19 @@ export async function gnapServerErrorMiddleware( | |||
| 'Received error when handling Open Payments GNAP request' | |||
There was a problem hiding this comment.
main changes here: don't throw error, but return status & body. Follows error handling koa docs: https://github.com/koajs/koa/blob/master/docs/error-handling.md
mkurapov
commented
Jun 21, 2024
Comment on lines
+85
to
+87
| ctx.body = { | ||
| error: { description: err.message } | ||
| } |
There was a problem hiding this comment.
this is not a GNAP error per se, just a validation error, for which we just add the description
mkurapov
commented
Jun 21, 2024
Comment on lines
+85
to
+87
| ctx.body = { | ||
| error: { description: err.message } | ||
| } |
There was a problem hiding this comment.
this is not a GNAP error per se, just a validation error, for which we just add the description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Updates how errors are displayed when making requests to the AS, to be more in-line with the spec. This improves error handling in general as it allows for parsing error codes, and making use of the description.
Before:
After:
This PR also adds some if-checks to the OP post requests scripts in bruno, in order not to prevent any errors from being hidden, since when post requests scripts would fail to parse response body information, the script error would override the actual response error.
Context
General OP error handling #1905
Checklist
fixes #number