Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outgoing-payment): add grantId to admin api #2841

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

golobitch
Copy link
Collaborator

@golobitch golobitch commented Aug 5, 2024

Changes proposed in this pull request

  • update GraphQL schema for outgoing payment to also include grantId

Context

fixes #2836

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@golobitch golobitch requested a review from mkurapov August 5, 2024 21:03
@golobitch golobitch self-assigned this Aug 5, 2024
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 44041ae
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66b25538bd2c9a0008e00685

…ayment

When querying outgoing payment, either single one, or list of them via pagination, etc., it will be
possible to also get a grantId under which the outgoing
@golobitch golobitch force-pushed the feature/2836-grantid-outgoing-payment branch from 8b1eae4 to 44041ae Compare August 6, 2024 16:54
@golobitch golobitch merged commit aac63c7 into main Aug 7, 2024
42 checks passed
@golobitch golobitch deleted the feature/2836-grantid-outgoing-payment branch August 7, 2024 19:54
sabineschaller pushed a commit that referenced this pull request Aug 15, 2024
* feat(backend): support for returning grantId when querying outgoing payment

When querying outgoing payment, either single one, or list of them via pagination, etc., it will be
possible to also get a grantId under which the outgoing

* test(outgoing-payment): check if grantId is returned

* docs(bruno): include grantId when fetching outgoing payment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grantId to outgoing payment AdminAPI queries
2 participants