Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): switch to alpine3.19 #2842

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat(docker): switch to alpine3.19 #2842

merged 4 commits into from
Aug 6, 2024

Conversation

golobitch
Copy link
Collaborator

@golobitch golobitch commented Aug 5, 2024 •
edited
Loading

  • feat(auth): build with alpine3.19
  • feat(backend): build with alpine3.19
  • feat(frontend): build with alpine3.19

Due to one CVE, our CI builds are failing due to some CVE that was not fixed in alpine3.18, so I decided that maybe we can bump that up a little bit. So I did an upgrade from alpine3.18 to alpine3.19

@golobitch golobitch self-assigned this Aug 5, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 7e4dde3
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66b253020699800008bb6756

@github-actions github-actions bot added pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: auth Changes in the GNAP auth package. labels Aug 5, 2024
@golobitch golobitch changed the title feature/switch to alpine319 build(docker): switch to alpine3.19 Aug 5, 2024
@golobitch golobitch changed the title build(docker): switch to alpine3.19 feat(docker): switch to alpine3.19 Aug 5, 2024
koekiebox
koekiebox previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

koekiebox
koekiebox approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@golobitch golobitch merged commit 8338dfc into main Aug 6, 2024
42 checks passed
@golobitch golobitch deleted the feature/switch-to-alpine319 branch August 6, 2024 16:52
sabineschaller pushed a commit that referenced this pull request Aug 15, 2024
@golobitch @sabineschaller
feat(docker): switch to alpine3.19 (#2842)
7ef4d44 
* feat(auth): build with alpine3.19

* feat(backend): build with alpine3.19

* feat(frontend): build with alpine3.19

* bump(localenv): docker image to alpine 3.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koekiebox koekiebox koekiebox approved these changes

@BlairCurrey BlairCurrey Awaiting requested review from BlairCurrey

@mkurapov mkurapov Awaiting requested review from mkurapov

Assignees

@golobitch golobitch

Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-ase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golobitch @koekiebox