fix(backend): incoming payment action resolvers #2865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will add two new table columns in the incomingPayments table on the backend service. ASE will be able to call cancel or approve incoming payment GraphQL API, and the timestamp of the call will be save in the database under these two fields. Normally, both of these two fields are optional.
This commit introduces possibility, to approve incoming payment through Admin API. API can be called with existing incoming payment as ID. Rafiki will fetch the incoming payment and update it's approvedAt field in the database. In case that payment does not exists or that it is not in the PENDING state, appropriate error is returned. #2811
It will be possible to cancel incoming payment due to some requirements. Rafiki just need to get a call to cancel incoming payment, with the payment ID. If transaction is in PENDING state and it is in the database, then it will get updated. It's cancelledAt field will be set to current time. #2811
…ncel incoming payment API #2811
…ing payments Introduced three new env variables that will set the behaviour of actionable incoming payments. One env variable will define if polling will be done, meaning that it will wait for the incoming payment to be accepted or rejected, and other two env variables defines timeout for polling and polling frequency
…st.ts Co-authored-by: Max Kurapov <[email protected]>
Our builds are failing due to Trivy scanner. Trivy scanner actually found that our Axios version v1.6.8 has a vulnerability - CVE-2024-39338. This was fixed in version 1.7.4, hence, the upgrade. fix #2860
github-actions
bot
added
type: tests
Base automatically changed from
feature/2811-actionable-incoming-payments
to
main
August 21, 2024 15:07
|
@BlairCurrey can we close this? |
I think we can yes. @BlairCurrey helped me a lot with the review of Actionable incoming payments, and I had a mess in Bruno files, so Blair helped and fixed that. Since we already merged actionable incoming payments, yes, we can probably close this. |
|
Yeah it was some suggestions from the PR that has already been merged. Not needed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #number