Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): ww performance create quote metrics #2896

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

BlairCurrey
Copy link
Contributor

Running 5 VUs for 2 minutes

VUs: 5
Durations: 120s
Iterations: 3113 25.914919/s
p(90)=225.94ms

data_received..................: 3.2 MB 27 kB/s
     data_sent......................: 5.4 MB 45 kB/s
     http_req_blocked...............: avg=1.88µs   min=458ns  med=1.66µs   max=427.2µs  p(90)=2.29µs   p(95)=2.54µs  
     http_req_connecting............: avg=44ns     min=0s     med=0s       max=154.25µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=64.23ms  min=5.67ms med=52.18ms  max=2.15s    p(90)=111.75ms p(95)=120.94ms
       { expected_response:true }...: avg=64.23ms  min=5.67ms med=52.18ms  max=2.15s    p(90)=111.75ms p(95)=120.94ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 9334
     http_req_receiving.............: avg=40.17µs  min=7.04µs med=39.87µs  max=638.37µs p(90)=54.69µs  p(95)=59.47µs 
     http_req_sending...............: avg=10.64µs  min=2.54µs med=9.29µs   max=1.66ms   p(90)=12.7µs   p(95)=14.2µs  
     http_req_tls_handshaking.......: avg=0s       min=0s     med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=64.18ms  min=5.59ms med=52.12ms  max=2.15s    p(90)=111.7ms  p(95)=120.89ms
     http_reqs......................: 9334   77.703135/s
     iteration_duration.............: avg=192.79ms min=6.29ms med=188.46ms max=2.29s    p(90)=225.94ms p(95)=243.42ms
     iterations.....................: 3113   25.914919/s
     vus............................: 5      min=5       max=5 
     vus_max........................: 5      min=5       max=5 


running (2m00.1s), 0/5 VUs, 3113 complete and 0 interrupted iterations
default ✓ [ 100% ] 5 VUs  2m0s

This is a point where performance is starting to degrade but isn’t outright failing.

Screenshot 2024-08-26 at 5 17 18 PM

I am going into the highest duration resolver (createQuoteMutation) and finding the largest span and adding more metrics. This has shown the quote service’s paymentMethodHandlerService.getQuote call is taking the most time (blue on left - green is entire quote create). paymentMethod.startQuote call is taking the most time, and in getQuote (blue from the right image, green is the total for getQuote.

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Aug 26, 2024
@BlairCurrey BlairCurrey changed the title Bc/ww performance create quote metrics bc: ww performance create quote metrics Aug 26, 2024
@BlairCurrey BlairCurrey changed the title bc: ww performance create quote metrics feat(backend): ww performance create quote metrics Aug 26, 2024
@BlairCurrey BlairCurrey merged commit e63608b into bc/ww-performance Aug 26, 2024
31 of 34 checks passed
@BlairCurrey BlairCurrey deleted the bc/ww-performance-create-quote-metrics branch August 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant