Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): create operator kratos identity on backend startup #2909

Merged
merged 5 commits into from
Sep 2, 2024
Merged

feat(backend): create operator kratos identity on backend startup #2909

merged 5 commits into from
Sep 2, 2024

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Aug 28, 2024 •
edited
Loading

Changes proposed in this pull request

  • Kratos is no longer optional when composing the local environment from pnpm script
    • TODO later: make Kratos not optional at all levels
  • On startup, backend service generates a Kratos identity with the metadata property operator: true, which will be used to determine if the identity is an operator versus a tenant of the Rafiki instance.
  • Added KRATOS_ADMIN_EMAIL and KRATOS_ADMIN_URL environment variables to the backend package.

Context

Fixes #2903.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@njlie njlie requested a review from golobitch August 28, 2024 07:32
@github-actions github-actions bot added pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic labels Aug 28, 2024
@njlie njlie requested a review from sanducb August 28, 2024 07:32
@njlie njlie force-pushed the nl/2903/startup-admin-role branch from 843ba2b to 42fd6d2 Compare August 28, 2024 09:11
@github-actions github-actions bot added the type: tests Testing related label Aug 28, 2024
golobitch
golobitch approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@golobitch golobitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@golobitch golobitch merged commit f15f6de into 2893-multi-tenant-rafiki Sep 2, 2024
36 checks passed
@golobitch golobitch deleted the nl/2903/startup-admin-role branch September 2, 2024 15:54
@golobitch golobitch mentioned this pull request Sep 2, 2024
Closed
@njlie njlie mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golobitch golobitch golobitch approved these changes

@sanducb sanducb Awaiting requested review from sanducb

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njlie @golobitch