Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): fix tests broken by multi-tenancy #3014

Open
wants to merge 1 commit into
base: 2893-multi-tenant-rafiki
Choose a base branch
from
Open

feat(auth): fix tests broken by multi-tenancy #3014

wants to merge 1 commit into from

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Oct 2, 2024 •
edited
Loading

Changes proposed in this pull request

  • Fixes all auth tests that have a tenantId constraint.
    • Adds tenantId to grants when they are created in tests.

Context

Fixes #3009.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related type: source Changes business logic pkg: auth Changes in the GNAP auth package. labels Oct 2, 2024
@njlie njlie marked this pull request as ready for review October 3, 2024 16:57
@njlie njlie force-pushed the nl/3009/fix-auth-package-tests branch 2 times, most recently from adbe8aa to a77ea0b Compare October 10, 2024 20:13
@njlie njlie force-pushed the nl/3009/fix-auth-package-tests branch from a77ea0b to adbe8aa Compare November 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCurrey BlairCurrey Awaiting requested review from BlairCurrey

@mkurapov mkurapov Awaiting requested review from mkurapov

@golobitch golobitch Awaiting requested review from golobitch

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njlie