Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: make Webhook event type an enum #3021

Closed
wants to merge 3 commits into from

Conversation

oana-lolea
Copy link
Contributor

Changes proposed in this pull request

  • Added WebhookEventType enum that contains all the possible webhook event types
  • Added utility enums that contain members of the WebhookEventType enum (for incoming payments, wallet address etc.)

Context

I created WebhookEventType enum that contains all the possible webhook event types. This changes the type format to the standard enum format (uppercase words separated by underscore, e.g. 'INCOMING_PAYMENT_CREATED'), therefore a migration was needed to update the existing types.
Due to this change, I added subsets of this enum for classes that extend WebhookEvent.
Tests were also updated using the new enum.

Fixes #2786

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: documentation Changes in the documentation package. pkg: mock-account-service-lib labels Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit cd17b1b
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6704fcc1a96607000861cdfd
😎 Deploy Preview https://deploy-preview-3021--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oana-lolea oana-lolea closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Webhook Event types an enum in the Admin API
1 participant